Update to bootstrap v4.x #9977
Closed
Update to bootstrap v4.x #9977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I thought it would be a good idea to update because bootstrap is now full scss and therefore the package bootstrap-sass is outdated
|
@Etilawin thanks so much for this contribution! Moreover, it's your first pull request ever on GitHub, so it's cool that you submitted it to the Symfony project. We love that ❤️ Sadly, and trust me that I'm really sorry, this is a duplicate of another pull request that was sent a few days ago and is still pending to be merged: #9918. I'm really sorry and I wish I could merge both pull requests, but we can't do that and that's why we must close your pull request without merging it. We're looking forward to receive more contributions from you in the future. Thanks! |
|
No problem, it's good someone noticed and proposed a correction |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought it would be a good idea to update because bootstrap is now full scss and therefore the package bootstrap-sass is outdated